mTLS Pop package for msi related flows with a new mtls api #5413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gladjohn
commented
Jul 30, 2025
| { | ||
| // Preserve Win32 error code for diagnosis | ||
| int err = Marshal.GetLastWin32Error(); | ||
| throw new Win32Exception(err, $"Unable to load {path}"); |
There was a problem hiding this comment.
need to remove throw, and silently fail, maybe with a warning. But using this for testing now.
gladjohn
force-pushed
the
gladjohn/msal_msi_attestation
branch
3 times, most recently
from
a5d3073 to
6d865aa
Compare
gladjohn
changed the title
gladjohn
force-pushed
the
gladjohn/msal_msi_attestation
branch
from
6d865aa to
0128add
Compare
bgavrilMS
reviewed
Sep 4, 2025
| <!--This should be passed from the VSTS build--> | ||
| <MicrosoftIdentityClientVersion Condition="'$(MicrosoftIdentityClientVersion)' == ''">$(MsalInternalVersion)</MicrosoftIdentityClientVersion> | ||
| <!--This will generate AssemblyVersion, AssemblyFileVersion and AssemblyInformationVersion--> | ||
| <Version>$(MicrosoftIdentityClientVersion)</Version> |
DharshanBJ
reviewed
Sep 4, 2025
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
is this empty file needed?
DharshanBJ
reviewed
Sep 4, 2025
| @@ -1,4 +1,4 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
There was a problem hiding this comment.
all the changes in this file are related to spacing, are these changes necessary?
DharshanBJ
reviewed
Sep 4, 2025
| This package contains binaries needed to use managed identity proof-of-possession (MTLS PoP) flows in applications using MSAL.NET. | ||
| </Description> | ||
| <PackageTags>Microsoft Authentication Library Managed Identity MSAL Proof-of-Possession</PackageTags> | ||
| <Product>Microsoft Authentication Library Broker</Product> |
There was a problem hiding this comment.
should the Product name here include 'Broker'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # Adds Managed Identity Pop package
Changes proposed in this request
This pull request adds support for attestation and key import functionality to the solution, primarily by introducing the new
Microsoft.Identity.Client.MtlsPopproject. It includes managed wrappers for native attestation operations, logging, error handling, and result representation, as well as updates to the solution and build pipeline to integrate and sign the new NuGet package.Attestation and Key Import Functionality
Microsoft.Identity.Client.MtlsPopto the solution, providing managed wrappers for native attestation operations viaAttestationClient,AttestationClientLib, and related types. This enables secure key attestation and import using native libraries. [1] [2] [3] [4] [5] [6]Build and Solution Integration
LibsAndSamples.slnto includeMicrosoft.Identity.Client.MtlsPopandKeyGuardAttestationprojects, with full configuration mappings for build and platform targets. [1] [2] [3]build/template-pack-and-sign-all-nugets.yaml) to pack and sign the newMicrosoft.Identity.Client.MtlsPopassembly, ensuring it is included in release artifacts.Miscellaneous
CHANGELOG.mdfrom the solution items inLibsAndSamples.sln.Testing
integration tests
Performance impact
none
Documentation